-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add npm actions to generate the licenses files #2116
base: master
Are you sure you want to change the base?
Conversation
@daniellacosse I couldn't get it to work properly on workspaces without specifying both the root and workspace |
Perhaps you could have a root license file sent to Do we need to commit these? Can we just generate them at build time? If not, they should probably live in a |
That's what I suggested in the PR description. Agree it should be at build time but I don't have time for that right now. This at least brings the license files up-to-date.
They shouldn't live in |
That doesn't really solve the problem that there's no way to identify which root dependencies belong to which workspace. It's probably fine like this. |
0f46e10
to
40d6fa2
Compare
Ideally this is done at build time instead of manually, but I don't have time to look into that right now. Leaving that for a future PR.